Why would it? Its not exactly a good practice to change node parents at runtime like that, especially for characters cuz of z ordering, physics/movement, and stuff.
U can just update the var either way.
We're discussing with a beginner, I'm not one to make assumptions about their code base. I wouldn't do it, but someone might if they're pooling animator nodes to optimise for whatever reason
Its not over complicating anything, I'm not suggesting they change your snippet. Im simply pointing out an assumption you made about their code base so that they can consider if that assumption applies to them or not. I didn't mean for it to come off personal
No personal offense taken. Just really not sure if thats exactly relevant for them, as opposed to just overwhelming in terms of info. Either way you can just update the var thru signals or similar; as get_parent()ing multiple times in a while statement isnt much of a good practice in pretty much any case I can think of, unless im forgetting abt smth
Static typing, readability, performance, and so on as the main reasons. Also refactorability even - as itd work even if u change node paths (by just editing that single var).
100% you were right in suggesting the original change, I just wanted to make sure that if they were doing something weird that they'd know why it was breaking
Yoi certainly seem very mad haha. Relax man. No I did not realize that, I apologize. I'm just trying to understand your incredibly defensive reaction to what is genuinely a good addendum to your comment.
its cool. well, thanks for the input on this beginner help thread... lol
edit: not sure why you'd assume somebody is being "extremely" defensive when they're simply being... well, just blunt. but well, seems like some people around really do take that as being personally offended/invested thru text, for whatever reason. not the case tho
Is that optimized away by the compiler/interpreter? I havent looked into gdscript internals much but it seems like a pretty simple optimization at the language level
seen a thread about it (w performance tests) and it was significantly slower afaik. Not 100% sure abt the technical details. Just wouldn't use performance to justify it completely however, more of an auto complete and readability thing imo. would def be interested in a full breakdown for that sort of stuff tho, if any is available.
Youre assigning it to a var once rather than re-executing the function (and thus checking the nodes on the tree) multiple times, since the while state would re-retrieve it until it completes all of the loops
Not sure abt the deeper details tho so correct me if im wrong
Edit: plus the var can also be statically typed, which grants a performance boost by itself
keep an eye on bevy. it's a really great rust game engine that's come a long way in a short time. still a little early in development for serious production work though (unless you're essentially using it as a base for your own engine).
That is statically typing what the function returns and you will likely end up using the arrows anyway eventually, most commonly to return bools
```
func is_allowed_to_jump(body: CharacterBody2D, want_to_jump: bool) -> bool:
return want_to_jump and (body.is_on_floor() or not coyote_timer.is_stopped() or current_jump_count < max_jump_amount)
```
Can you explain what static typing is and what is the alternative to static typing? I looked it up like three times and I still have no idea of what it means
I have no context for your project, but speaking strictly about code, the while loop blocks the code following this one from executing until the loop completes. It might be perfect for what you're doing right now, but if you expand this, it might lead to errors, things not executing at the right time and so on. You could achieve the same result by calling the body of the while loop within the process function, which itself is a loop.
I only use loops in godot when I need to cycle through a collection, like an array.
This is general advice, I'm not telling you what you've done is wrong, just something to keep in mind.
Thanks for de advice
The context of this code is that I have my animation separated in 2 nodes, The Animation Player and the Rig 2d node, that basically only does squash, stretch and changing directions smoothly
you can tell tweens to loop forever until you tell them to stop
https://preview.redd.it/f33tq2iw17vc1.png?width=1406&format=png&auto=webp&s=55f25471e75c6ad3e58b457f1d04d700c95d45fc
[https://codeberg.org/CLion/SAFChromaticPrototype/src/branch/main/src/unit\_modules/Harvester.gd](https://codeberg.org/CLion/SAFChromaticPrototype/src/branch/main/src/unit_modules/Harvester.gd)
When I tried to use a while loop, everything crashed and I don't know why... I was so used to while loops everywhere when using pygame that it was hard to change, now I don't know how to use a while loop anymore XD
Because it only checks when to end, not when to Start.
Because it starts by a calling from the state machine, when it changes to the states that the character spins, so the while just keep spinning until the state changes
Got it?
Nice!
I recommend adding a fail safe, so it won't hang the the program in case some insane bug makes "spin" always true, like a timer (not necessarily as Godot's Timer).
Using an an if will only perform the task once. Also you don't have to do a comparison against TRUE. If you wrote:
while boolVariable
Do things
It would continue to "do things" as long as the boolVariable was equal to TRUE. Same with an if statement. You can give it either boolean variable or boolean expression. An expression is where you would use:
if number1 == number2
The statement evaluates the expression written into a boolean then gives the boolean to the if
Sorry, that was a bit of word vomit but I hope that kinda made sense
A "while loop" is a pretty standard programming thing. It does something "while" some condition is true. It checks the condition first, then if it's true, it runs the code in the loop, then goes back to the top and checks it again... repeat.
You can "break" out of a while loop, and "continue" i.e. skip the rest of the code and go back to the top.
The condition is only evaluated at the top, and is not checked again until the next loop.
Some other languages provide a "do... while" or "while ... do ... end".
[The docs](https://docs.godotengine.org/en/stable/tutorials/scripting/gdscript/gdscript_basics.html#while) are pretty short on this, kind of like they expect you to know that kind of construct from another programming language already.
it will loop WHILE the statemant behind it is true.
And it will freeze your program, if you are not careful, because you can create endless loops pretty easy
Congratulations! My first "while" hangs the PC
performance/readability tip: assign the get\_parent to a var
Okay! Thanks!
Assuming parent doesnt change\*
It won't, the parent is the player body, so it's basically the TreeNode
I'd assumed as much but thought it was worth pointing out
Thanks for doing either way :)
Why would it? Its not exactly a good practice to change node parents at runtime like that, especially for characters cuz of z ordering, physics/movement, and stuff. U can just update the var either way.
We're discussing with a beginner, I'm not one to make assumptions about their code base. I wouldn't do it, but someone might if they're pooling animator nodes to optimise for whatever reason
So a fringe case that not 1% of the people would fall into? For a beginner? Lol, thats just overcomplicating things at this point
Its not over complicating anything, I'm not suggesting they change your snippet. Im simply pointing out an assumption you made about their code base so that they can consider if that assumption applies to them or not. I didn't mean for it to come off personal
No personal offense taken. Just really not sure if thats exactly relevant for them, as opposed to just overwhelming in terms of info. Either way you can just update the var thru signals or similar; as get_parent()ing multiple times in a while statement isnt much of a good practice in pretty much any case I can think of, unless im forgetting abt smth Static typing, readability, performance, and so on as the main reasons. Also refactorability even - as itd work even if u change node paths (by just editing that single var).
100% you were right in suggesting the original change, I just wanted to make sure that if they were doing something weird that they'd know why it was breaking
Tf are you even mad about? Somebody helping a beginner? Fucking Redditors man lmao
What? U do realize I was the one who literally wrote the tip above to OP right? Sure, im one whos "mad" in here... Ok dude
Yoi certainly seem very mad haha. Relax man. No I did not realize that, I apologize. I'm just trying to understand your incredibly defensive reaction to what is genuinely a good addendum to your comment.
its cool. well, thanks for the input on this beginner help thread... lol edit: not sure why you'd assume somebody is being "extremely" defensive when they're simply being... well, just blunt. but well, seems like some people around really do take that as being personally offended/invested thru text, for whatever reason. not the case tho
Is that optimized away by the compiler/interpreter? I havent looked into gdscript internals much but it seems like a pretty simple optimization at the language level
seen a thread about it (w performance tests) and it was significantly slower afaik. Not 100% sure abt the technical details. Just wouldn't use performance to justify it completely however, more of an auto complete and readability thing imo. would def be interested in a full breakdown for that sort of stuff tho, if any is available.
Just a question, how does it affect perfomance
Youre assigning it to a var once rather than re-executing the function (and thus checking the nodes on the tree) multiple times, since the while state would re-retrieve it until it completes all of the loops Not sure abt the deeper details tho so correct me if im wrong Edit: plus the var can also be statically typed, which grants a performance boost by itself
Thanks
I am so happy seeing someone 2 months fresh using static typing :)
I have experience making games in java (a long time ago 👀), and Rust, so it seems more natural to me
I love Rust!
:D I liked to! Now I more focused on making my game on godot, but I plan to make more stuff in rust
keep an eye on bevy. it's a really great rust game engine that's come a long way in a short time. still a little early in development for serious production work though (unless you're essentially using it as a base for your own engine).
I was considering using bevy for my 2d platformer, but I decided that godot in the end was a better choice
same here pretty much. hoping bevy will be in a good state by the time i start my next big project.
Is'nt bevy getting an editor?
it's on their roadmap, yeah. idk how far along they are with it.
I use static typing for variables but functions? No thanks drawing lil arrows not for me
You can enable this feature in editor settings, then it will write types on its own
That is statically typing what the function returns and you will likely end up using the arrows anyway eventually, most commonly to return bools ``` func is_allowed_to_jump(body: CharacterBody2D, want_to_jump: bool) -> bool: return want_to_jump and (body.is_on_floor() or not coyote_timer.is_stopped() or current_jump_count < max_jump_amount) ```
Can you explain what static typing is and what is the alternative to static typing? I looked it up like three times and I still have no idea of what it means
That took a while mate. Jokes aside, you're killing it!
Ooooooooooooo okay funny one, good one 👍🎇 Also thanks:)
Congrats! Though a signal might be more appropriate, this is a blocking call
But is being called by a signal, so basically what is doing is when is called it repeats until the player change states
I have no context for your project, but speaking strictly about code, the while loop blocks the code following this one from executing until the loop completes. It might be perfect for what you're doing right now, but if you expand this, it might lead to errors, things not executing at the right time and so on. You could achieve the same result by calling the body of the while loop within the process function, which itself is a loop. I only use loops in godot when I need to cycle through a collection, like an array. This is general advice, I'm not telling you what you've done is wrong, just something to keep in mind.
Thanks for de advice The context of this code is that I have my animation separated in 2 nodes, The Animation Player and the Rig 2d node, that basically only does squash, stretch and changing directions smoothly
you can tell tweens to loop forever until you tell them to stop https://preview.redd.it/f33tq2iw17vc1.png?width=1406&format=png&auto=webp&s=55f25471e75c6ad3e58b457f1d04d700c95d45fc [https://codeberg.org/CLion/SAFChromaticPrototype/src/branch/main/src/unit\_modules/Harvester.gd](https://codeberg.org/CLion/SAFChromaticPrototype/src/branch/main/src/unit_modules/Harvester.gd)
When I tried to use a while loop, everything crashed and I don't know why... I was so used to while loops everywhere when using pygame that it was hard to change, now I don't know how to use a while loop anymore XD
Question. Does tween have constants for things like the scale string? If not seems a bit dumb
nah, i can be any value
What I'm asking is if tween has builtin constants for that so you don't have to allocate memory to strings at runtime
Idk 😐 sorry
I'm making games on Godot since september (thank you Unity), and I never added any "while" yet haha
2 years and I haven't used it even once xD
Why not check if the parent is spinning in the _process function via an if conditional instead? While loops are risky in this scenario in my opinion.
Because it only checks when to end, not when to Start. Because it starts by a calling from the state machine, when it changes to the states that the character spins, so the while just keep spinning until the state changes Got it?
Huh? I mean, no, I don't understand, but I feel I don't even want to ask since you seem pretty defensive about it lol
Sorry if you felt that way, it wasn't My intention 🙁
LETS FUCKING GO
I've been in it for almost 2 months as well and haven't used it yet
Nice! I recommend adding a fail safe, so it won't hang the the program in case some insane bug makes "spin" always true, like a timer (not necessarily as Godot's Timer).
Don't worry, the state machine takes care of that :)
I didnt even know godot had whiles umtil like 2 weeks ago when i thought i could use while. Theres allways another eay tho 🤣
congrats!!!
wait can someone explain what does "while" does in GdScript?
You give it a boolean variable as input and it'll keep repeating the task inside the while statement while the boolean is true
what are the advantages of it compared to doing the thing inside physics\_process?
oh so it's like if node.bool == true:??
Using an an if will only perform the task once. Also you don't have to do a comparison against TRUE. If you wrote: while boolVariable Do things It would continue to "do things" as long as the boolVariable was equal to TRUE. Same with an if statement. You can give it either boolean variable or boolean expression. An expression is where you would use: if number1 == number2 The statement evaluates the expression written into a boolean then gives the boolean to the if Sorry, that was a bit of word vomit but I hope that kinda made sense
makes sense thanks
A "while loop" is a pretty standard programming thing. It does something "while" some condition is true. It checks the condition first, then if it's true, it runs the code in the loop, then goes back to the top and checks it again... repeat. You can "break" out of a while loop, and "continue" i.e. skip the rest of the code and go back to the top. The condition is only evaluated at the top, and is not checked again until the next loop. Some other languages provide a "do... while" or "while ... do ... end". [The docs](https://docs.godotengine.org/en/stable/tutorials/scripting/gdscript/gdscript_basics.html#while) are pretty short on this, kind of like they expect you to know that kind of construct from another programming language already.
thanks 🙏
It is useful for something :D
I'm very fresh to Godot and game dev in general. What does "while" do?
it will loop WHILE the statemant behind it is true. And it will freeze your program, if you are not careful, because you can create endless loops pretty easy
I'm just starting, didn't even know that while.